chore(ci): add arm64 for macOS #1212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
force-pushed
the
ci-arm64
branch
from
3119e22 to
b525cd3
Compare
diegomrsantos
changed the title
lchenut
reviewed
Oct 11, 2024
Co-authored-by: Ludovic Chenut <[email protected]>
| @@ -75,7 +81,7 @@ jobs: | |||
| - name: Setup Go | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: '~1.15.5' | |||
| go-version: '~1.16.0' # That's the minimum Go version that works with arm. | |||
There was a problem hiding this comment.
Would you mind updating the README accordingly so this gets reflected? That is, that we support 1.16.0 onwards.
| @@ -87,8 +93,8 @@ jobs: | |||
| with: | |||
| path: nimbledeps | |||
| # Using nim.branch as a simple way to differentiate between nimble using the "pkgs" or "pkgs2" directories. | |||
| # The change happened on Nimble v0.14.0. | |||
| key: nimbledeps-${{ matrix.nim.branch }}-${{ hashFiles('.pinned') }} # hashFiles returns a different value on windows | |||
| # The change happened on Nimble v0.14.0. Also forcing the deps to be reinstalled on each os and cpu. | |||
There was a problem hiding this comment.
What changed for this to matter?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the macOS 14 GitHub runner that uses the arm64 cpu.