19/WAKU2-LIGHTPUSH: Update

[jimstir]

Updating the 19/WAKU2-LIGHTPUSH rfc. Waku specs repo has a new rfc becuase the current specification is under specified. Information from that update is included with some changes. Also introduced the term edge nodes in this update.

[jimstir]

Can a light node (edge node) and a service node be considered a lightpush client?

[jm-clius]

Within the context of lightpush and other req-resp protocols the protocol agents are always client and service node ("server" is sometimes used though somewhat less accurate IMO). I would stay away from "light node"/"edge node" within the context of req-resp protocol specifications. I think it's OK to use these terms in the motivation/background part only to explain why some nodes may choose to act as lightpush client. Edge nodes would typically prefer client mode, though these nodes all exist on a continuum of resource usage. In other words, "lightpush client" would be correct in this specific context as it refers to protocol behaviour.

[jm-clius]

Without having reviewed in detail, I'm wondering if this update is premature? Waku specs repo indeed has a new version of the lightpush spec as experimental improvement, but I would suggest that the implementation and deployment reach some level of maturity before we replace the existing RFC (as this one is already in draft and matches the implementation). Both versions of the protocol will be supported for a while @NagyZoltanPeter can comment on maturity of the "new" protocol implementation. Once most clients have switched over, we can deprecate the old lightpush version - both the RFC and the implementation.

[NagyZoltanPeter]

Without having reviewed in detail, I'm wondering if this update is premature? Waku specs repo indeed has a new version of the lightpush spec as experimental improvement, but I would suggest that the implementation and deployment reach some level of maturity before we replace the existing RFC (as this one is already in draft and matches the implementation). Both versions of the protocol will be supported for a while @NagyZoltanPeter can comment on maturity of the "new" protocol implementation. Once most clients have switched over, we can deprecate the old lightpush version - both the RFC and the implementation.

Thanks @jm-clius, yes. new redesigned v2 of lightpush protocol is under development, spec available here: https://github.com/waku-org/specs/blob/master/standards/core/lightpush.md
cc: @jimstir, of course any comments are welcome.

[NagyZoltanPeter]

Without having reviewed in detail, I'm wondering if this update is premature? Waku specs repo indeed has a new version of the lightpush spec as experimental improvement, but I would suggest that the implementation and deployment reach some level of maturity before we replace the existing RFC (as this one is already in draft and matches the implementation). Both versions of the protocol will be supported for a while @NagyZoltanPeter can comment on maturity of the "new" protocol implementation. Once most clients have switched over, we can deprecate the old lightpush version - both the RFC and the implementation.

Thanks @jm-clius, yes. new redesigned v2 of lightpush protocol is under development, spec available here: https://github.com/waku-org/specs/blob/master/standards/core/lightpush.md cc: @jimstir, of course any comments are welcome.

@jimstir sorry I did not see your changes are based upon that spec... but yes, we are planning to have a slow rollover to the new protocol, leaving enough time to switch.

[jimstir]

Thanks for the feedback. Closing this pr, as this RFC will become deprecated in the future and replaced with the new light push protocol located https://github.com/waku-org/specs/blob/master/standards/core/lightpush.md.