Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Box flexBasis or minWidth #157

Closed
duncanbeevers opened this issue Mar 13, 2019 · 4 comments
Closed

Support for Box flexBasis or minWidth #157

duncanbeevers opened this issue Mar 13, 2019 · 4 comments

Comments

@duncanbeevers
Copy link

In order to create consistent displays of side-by-side information, it may be useful to have boxes that shrink no smaller than some fixed size.

Without support for overflow behavior like clipping, width or maxWidth props seem a bit further out-of-reach.

Using a flexBasis prop provides similar functionality to a minWidth / minHeight, and feels less out-of-place than an orphaned minWidth with no width or maxWidth counterparts.

@vadimdemedes vadimdemedes changed the title Consider support for Box flexBasis or minWidth Support for Box flexBasis or minWidth Mar 18, 2019
@vadimdemedes
Copy link
Owner

Pushed support for min-width, min-height and flex-basis to master branch. Will add max-width and max-height once Ink implements overflow handling (wrapping) of individual nodes. Also discovered a potential Yoga issue along the way - facebook/yoga#872.

@vadimdemedes
Copy link
Owner

New release is out, which adds support for flexBasis, minWidth and minHeight props - https://github.com/vadimdemedes/ink/releases/tag/v2.1.0 🎆

@vadimdemedes
Copy link
Owner

Want to keep this issue open until facebook/yoga#872 is resolved and maxWidth/maxHeight are added too.

@vadimdemedes
Copy link
Owner

Closing, since facebook/yoga#872 has been open since 2019, so it's unlikely to get fixed anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants