-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate / support MSW 2 #76
Comments
Let me know if you have any questions/need help. Should be rather straightforward. The Migration guide should be all that you need. Thanks for this amazing project! |
Sorry, been crazy busy. Actually gonna give it a new try next week |
Hey @the-ult, thanks for the polite nudge to support MSW 2.0. I appreciate the offer for help and completely understand that you've been quite busy. I've started working on the migration and should hopefully have it done this weekend. @kettanaito Thanks for creating this amazing library and sharing the migration guide. Absolutely love all the examples, it's making this conversion a breeze 🙂 |
Thank you @valendres. That's awesome! |
Hey everyone, A huge thank you goes to @the-ult and @kettanaito for your detailed reviews, and @mamidenn for your initiative in addressing the feedback, as discussed in the corresponding PR. Your efforts have been crucial and are deeply appreciated. I apologize for the delay in supporting MSW 2. Balancing house moving, renovations, and attending AWS re:INVENT has made my schedule quite tight. But with re:INVENT behind us and the move nearly complete, I’m thrilled to finally have some time to get this release out. Although all of the integration tests in this repo are passing, the real-world usage is the ultimate test. I’m eager to hear your experiences with upgrading. If you encounter any issues or have feedback, please don’t hesitate to respond here, open a new issue, or submit a pull request. Your contributions are always welcomed and valued! |
Thank you for your incredible work on this, @valendres! 👏 |
@valendres should this issue be closed as the migration is done? Currently, it looks like the migration is still open. Thanks for your work! 😸 |
@valendres - although it's not really a "real-world" case yet, this library (at v3.0.1) worked well for me with Playwright and handlers created using MSW's Thanks for the library! |
With the new release of MSW, it would be great if playwright-msw supports it as well.
[edit]
Gonne give it a go to provide a PR if I can find some time this week
The text was updated successfully, but these errors were encountered: