Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to check for updates #3668

Closed
JustThat70 opened this issue Sep 11, 2024 · 22 comments
Closed

Unable to check for updates #3668

JustThat70 opened this issue Sep 11, 2024 · 22 comments

Comments

@JustThat70
Copy link

From the console:

[Updates] Configured update policy on this system: "Check for updates but let me choose whether to download and install them".
[Updates] Path to module: C:\Windows\dxgi.dll
[Updates] Using hardcoded hash.
[Updates] Checking against hash "22622.3880.66.5.320c4bb6f886ecab"
[Updates] Update URL: /download/ep_setup.exe
[Updates] Unable to check for updates because the remote server is unavailable.

I am on the internet and this worked up until I manually updated to this release. I've disabled the firewall and that does not resolve the issue

@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Sep 11, 2024

Check if notifications for Explorer are enabled.

I don't think the update URL is valid. Screenshot the updates section in your EP properties window.

@PierrotIV
Copy link

Same here:
[Updates] Configured update policy on this system: "Check for updates but let me choose whether to download and install them".
[Updates] Path to module: C:\Windows\dxgi.dll
[Updates] Using hardcoded hash.
[Updates] Checking against hash "22622.3880.66.5.320c4bb6f886ecab"
[Updates] Update URL: /download/ep_setup.exe
[Updates] Unable to check for updates because the remote server is unavailable.

Capture d'écran 2024-09-11 091016

It happens since I applied #3228

@pyrates999
Copy link

are you at a work network?

@PierrotIV
Copy link

are you at a work network?

Home but similar to a professional network.

@pyrates999
Copy link

Check your network then. And if you're going through a proxy, that might be blocking this.

@PierrotIV
Copy link

PierrotIV commented Sep 11, 2024

Check your network then. And if you're going through a proxy, that might be blocking this.

That was a good thought but:

  • it worked perfectly well before 22622.3880.66.5 update
  • no proxy here

Btw I checked and no dns request is sent when trying to check for updates, meaning the problem doesn't "get out" from the OS.

Other point I checked, I'm using Kaspersky as AV and firewall. I disabled it, meaning Windows Defender activates itself in place of Kaspersky, and that doesn't change the issue.

Just a thought: if someone using previous stable version could paste here the console output of a serch for update request, that might validate the validity of the update url (Amrsatrio point in his first answer to the OP).

@pyrates999
Copy link

Then disable Defender.

@PierrotIV
Copy link

Then disable Defender.

No change

@JayKay-Gitz
Copy link

Same issue here since updating to latest version. "Unable to check for updates"

  • Was working prior to 22621.3880.66.5 update
  • No vpn, proxy, other issues with network connections

@pyrates999
Copy link

Did you disable windows firewall? And then try to check for updates?

@JayKay-Gitz
Copy link

I just tried disabling Windows Defender Firewall, it didn't help. I also have no virus protection apart from windows defender. I did have the issue where i needed to add the paths to my exclusion list in defender in order to update to this version, but i don't think that's related. I tried disabling defender virus just in case, didn't help.

@ARM07470
Copy link

ARM07470 commented Sep 11, 2024

I had the same issue this morning and managed to fix it by setting HKEY_CURRENT_USER\Software\ExplorerPatcher\UpdateURL to https://github.com/valinet/ExplorerPatcher/releases/latest. That registry key was blank on my machine for some reason.

@PierrotIV
Copy link

Did you disable windows firewall? And then try to check for updates?

I did, no change.

@PierrotIV
Copy link

I had the same issue this morning and managed to fix it by setting HKEY_CURRENT_USER\Software\ExplorerPatcher\UpdateURL to https://github.com/valinet/ExplorerPatcher/releases/latest. That registry key was blank on my machine for some reason.

That worked, thank you!
Btw mine was also blank. I guess this is related to AV not allowing update in first place before I added the lines from #3228 .

@Amrsatrio
Copy link
Collaborator

Alright, I'll admit that I changed some stuff in the updater code so something might have slipped. If you don't mind helping me in troubleshooting the issue, does deleting the UpdateURL key fix it?

@PierrotIV
Copy link

Alright, I'll admit that I changed some stuff in the updater code so something might have slipped. If you don't mind helping me in troubleshooting the issue, does deleting the UpdateURL key fix it?

No problem.
Update was not working because HKEY_CURRENT_USER\Software\ExplorerPatcher\UpdateURL was empty.
Filling it with https://github.com/valinet/ExplorerPatcher/releases/latest did restore update functionality.

@JayKay-Gitz
Copy link

Alright, I'll admit that I changed some stuff in the updater code so something might have slipped. If you don't mind helping me in troubleshooting the issue, does deleting the UpdateURL key fix it?

I had already changed the key, but i just tried deleting the key and the update function is still working. Not sure if that would be the case if someone hadn't updated and tested it prior to deleting.

@Amrsatrio
Copy link
Collaborator

Amrsatrio commented Sep 11, 2024

Okay so the problem is if that key is present but empty then the updater won't work. Will fix it tomorrow.

By default that key does not exist.

@ARM07470
Copy link

I just deleted the key, restarted File Explorer and updates worked. Put it back w/no value and it stopped working. So, yes, the issue is if the key is present but empty. I never touched that key before, so I'm not sure when it got added w/a null value.

@s-renz
Copy link

s-renz commented Sep 11, 2024

does deleting the UpdateURL key fix it?

Yes. Just deleting it, without changing anything first, does fix it

Amrsatrio added a commit to Amrsatrio/ExplorerPatcher that referenced this issue Sep 12, 2024
@Apocalypse612
Copy link

Apocalypse612 commented Sep 14, 2024

Same issue here after running the .ps1 script provided to allow all EP updates through the Windows Defender firewall. Since the last update was complaining about viruses, I ran the script then got the update, then this error occurred. Can confirm that deleting the reg key listed above fixed the issue.

@Amrsatrio
Copy link
Collaborator

Promoted 66.6 into release - should fix the updates issue. Sorry for those who updated to 66.5 and used the Restore default settings in the past. I'll pin this.

@Amrsatrio Amrsatrio pinned this issue Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants