Rename hiredis-py to libvalkey-py #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing support for Python 3.7. Take the opportunity to better support Python 3.12 by adding setuptools to dev_requirements.
Bumps [black](https://github.com/psf/black) from 22.3.0 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.3.0...24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
aiven-sal
requested changes
Jul 4, 2024
There was a problem hiding this comment.
There is a "redis" in the tox.ini file. It might be a good idea to change it and run tox to see if it can find anything else.
Also the GH actions are not running because they are still targeting the master branch, but now we have main.
I didn't run the code, but it looks good.
Good catch, thanks! I did run the code, and it passes all the local tests :) Also, |
This commit renames the project and makes use of `libvalkey` instead of `hiredis`.
aiven-sal
reviewed
Jul 4, 2024
aiven-sal
approved these changes
Jul 4, 2024
It's never been used and contained incorrect config from the very beginning.
ahmedsobeh
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the project and makes use of
libvalkeyinstead ofhiredis.