Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document configs #154

Open
zuiderkwast opened this issue Jul 4, 2024 · 4 comments
Open

Document configs #154

zuiderkwast opened this issue Jul 4, 2024 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@zuiderkwast
Copy link
Contributor

Currently, we just refer to valkey.conf (the template config file) where the fields are described in comments. This isn't very good documentation.

Document each config parameter in the proper page valkey.conf.md. Instead of referring to the config files of different versions, we can mention for each field in which version it was introduced.

@zuiderkwast zuiderkwast added the help wanted Extra attention is needed label Sep 22, 2024
@melroy89
Copy link
Contributor

in which version it was introduced.

And if applicable when it's depreciated.

@rjd15372
Copy link

I also think this is a good idea. Having the config options description in our documentation is the way to go. But there's a maintenance burden here that we need to decide how to tackle on, because we will have duplicate information (in the valkey.conf file, and here in the documentation).

My take on this is that whenever a developer opens a PR with changes to the valkey.conf file in the valkey repo, the reviewers should ask the developer to also open a PR in the valkey-doc repo with updating the documentation. This way we distribute the burden of maintenance between all developers.

@zuiderkwast
Copy link
Contributor Author

Yes, for any feature that requires doc changes, we ask the developer to do it and we add the tag 'doc-pr-needed' to the PR.

Can I assign you to this issue? ;)

@rjd15372
Copy link

@zuiderkwast you can assign it to @nastena1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants