Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configure-aws-credentials instead of passing secret_access_key #1346

Open
vudiep411 opened this issue Nov 25, 2024 · 3 comments · May be fixed by #1363
Open

Use configure-aws-credentials instead of passing secret_access_key #1346

vudiep411 opened this issue Nov 25, 2024 · 3 comments · May be fixed by #1363

Comments

@vudiep411
Copy link

vudiep411 commented Nov 25, 2024

The problem/use-case that the feature addresses
API calls to AWS need to be signed with credential information, so when you use one of the AWS SDKs or an AWS tool, you must provide it with AWS credentials and and AWS region. One way to do that in GitHub Actions is to use a repository secret with IAM credentials, but this doesn't follow AWS security guidelines on using long term creds.

Description of the feature

- name: Configure AWS Credentials for China region audience
      uses: aws-actions/configure-aws-credentials@v4
      with:
        aws-region: us-east-3
        role-to-assume: arn:aws-cn:iam::123456789100:role/my-github-actions-role

By using this approach we can get rid off the secret keys needed to pass in and also organize the workflow

@madolson
Copy link
Member

@roshkhatri Can you look into this? I would love to get rid of long term credentials

@roshkhatri
Copy link
Member

Sure, I will also look in to it with @vudiep411 but he will primarily be looking into this. He is also from Amazon.

Meanwhile, @vudiep411 can you make these changes in your repo and raise a PR.
Once it looks good we can replicated those changes on valkey repo.

@vudiep411
Copy link
Author

yea definitely. I'm working on that right now on a DEV env AWS account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment