Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup follow-up: Delete code for shared integers #1358

Open
zuiderkwast opened this issue Nov 26, 2024 · 0 comments
Open

Cleanup follow-up: Delete code for shared integers #1358

zuiderkwast opened this issue Nov 26, 2024 · 0 comments

Comments

@zuiderkwast
Copy link
Contributor

zuiderkwast commented Nov 26, 2024

With this change (#1186), I'm fairly sure we never used shared objects anywhere in the codebase anymore. We might want to cleanup that code (can be a followup) to make sure we don't silently introduce bugs there and then forget about them if we use them again.

Originally posted by @madolson in #1186 (comment)

Update: We do use shared objects (string objects like shared.ok) but not shared integers, apart from a zero reply of some command.

@zuiderkwast zuiderkwast changed the title Cleanup follow-up: Delete code for shared objects Cleanup follow-up: Delete code for shared integers Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant