Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new hashtable for sorted sets #1096

Closed
Tracked by #169
zuiderkwast opened this issue Sep 30, 2024 · 0 comments · Fixed by #1427
Closed
Tracked by #169

Use new hashtable for sorted sets #1096

zuiderkwast opened this issue Sep 30, 2024 · 0 comments · Fixed by #1427

Comments

@zuiderkwast
Copy link
Contributor

No description provided.

@zuiderkwast zuiderkwast mentioned this issue Sep 30, 2024
Closed
5 tasks
@zuiderkwast zuiderkwast changed the title Use hashsets for sorted sets Use hashset for sorted sets Sep 30, 2024
@zuiderkwast zuiderkwast changed the title Use hashset for sorted sets Use new hashtable for sorted sets Nov 20, 2024
This was referenced Dec 5, 2024
Closed
Open
@zuiderkwast zuiderkwast mentioned this issue Dec 18, 2024
Merged
zuiderkwast added a commit that referenced this issue Jan 8, 2025
@SoftlyRaining @zuiderkwast
Replace dict with new hashtable: sorted set datatype (#1427)
ab627d6 
This PR replaces dict with hashtable in the ZSET datatype. Instead of
mapping key to score as dict did, the hashtable maps key to a node in
the skiplist, which contains the score. This takes advantage of
hashtable performance improvements and saves 15 bytes per set item - 24
bytes overhead before, 9 bytes after.

Closes #1096

---------

Signed-off-by: Rain Valentine <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
proost pushed a commit to proost/valkey that referenced this issue Jan 17, 2025
@SoftlyRaining @zuiderkwast @proost
Replace dict with new hashtable: sorted set datatype (valkey-io#1427)
bc21780 
This PR replaces dict with hashtable in the ZSET datatype. Instead of
mapping key to score as dict did, the hashtable maps key to a node in
the skiplist, which contains the score. This takes advantage of
hashtable performance improvements and saves 15 bytes per set item - 24
bytes overhead before, 9 bytes after.

Closes valkey-io#1096

---------

Signed-off-by: Rain Valentine <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]>
Signed-off-by: proost <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace dict with new hashtable: sorted set datatype SoftlyRaining/valkey
1 participant
@zuiderkwast