Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save config file after replica migration and brocast a PONG when role changed #1677

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Feb 6, 2025

This does some cleanup around clusterSetPrimary:

  1. In replica migration, the replica already has a new primary, we
    need to update the config file.
  2. When the role changed, we need to broadcast a PONG in the cluster
    to notify the change. This is a follow up for Brocast a PONG to all node in cluster when role changed #1295.

The replica already has a new primary, we need to update the
config file.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin requested a review from PingXie February 6, 2025 02:51
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.13%. Comparing base (110dd55) to head (d875efc).
Report is 53 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1677      +/-   ##
============================================
+ Coverage     71.05%   71.13%   +0.07%     
============================================
  Files           121      123       +2     
  Lines         65243    65611     +368     
============================================
+ Hits          46358    46670     +312     
- Misses        18885    18941      +56     
Files with missing lines Coverage Δ
src/cluster_legacy.c 86.05% <100.00%> (+0.12%) ⬆️

... and 32 files with indirect coverage changes

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin changed the title Trigger cluster config save and fsync after replica migration Save config file after replica migration and brocast a PONG when role changed Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant