Change redis to server in INFO fields redis_{git_sha1,git_dirty,build_id} #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and redis_build_id Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1736 +/- ##
============================================
- Coverage 71.17% 71.10% -0.08%
============================================
Files 123 123
Lines 65536 65536
============================================
- Hits 46645 46599 -46
- Misses 18891 18937 +46
|
madolson
reviewed
Feb 15, 2025
| "redis_git_sha1:%s\r\n", serverGitSHA1(), | ||
| "redis_git_dirty:%i\r\n", strtol(serverGitDirty(), NULL, 10) > 0, | ||
| "redis_build_id:%s\r\n", serverBuildIdString(), | ||
| "server_git_sha1:%s\r\n", serverGitSHA1(), |
There was a problem hiding this comment.
Some part of me says let's just leave them. One more thing to not list as a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields were mentioned in #41 but we didn't change them. I don't remember why.
I hope we can changing them in 9.0 when we're phasing out the redis compatibility fields.