Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better understand and define overall strategy for aux and data types #9

Closed
roshkhatri opened this issue Nov 28, 2024 · 1 comment · Fixed by #29
Closed

Better understand and define overall strategy for aux and data types #9

roshkhatri opened this issue Nov 28, 2024 · 1 comment · Fixed by #29
Assignees
@joehu21

Comments

@roshkhatri
Copy link
Member 

          Yeah, I think we need a better overall strategy here instead of install random types and ignoring the data from them.

Originally posted by @madolson in #1 (comment)
@roshkhatri roshkhatri mentioned this issue Nov 28, 2024
Merged
@joehu21
Copy link
Collaborator

joehu21 commented Dec 17, 2024 •
edited
Loading

I think we should just remove aux type registration and loading code that are not related to JSON, because during the load of ValkeyJSON module, we shouldn't care about any aux data types that do not belong to ValkeyJSON. In addition, when we talk about RDB compatibility with JSON type, it is under the condition that no other module types are present in the RDB.

Also see #19.

@joehu21 joehu21 self-assigned this Dec 17, 2024
@joehu21 joehu21 linked a pull request Dec 17, 2024 that will close this issue
Fix #19 - Remove aux type loading code not related to JSON #29
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joehu21 joehu21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #19 - Remove aux type loading code not related to JSON joehu21/valkeyJSON
2 participants
@joehu21 @roshkhatri