Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng2-dragula version 5.1.0 NOT working with Angular 17 - are you planning to support this feature? #1106

Open
5 tasks
ddn488 opened this issue May 3, 2024 · 4 comments

Comments

@ddn488
Copy link

ddn488 commented May 3, 2024

REQUIRED: Before filing a bug report

Change each [ ] to [x] when you have done it.

Describe the bug (required)

A clear and concise description of what the bug is. What did you do, and what
did you expected to happen? What happened instead?

To Reproduce (required)

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

If your issue appears in a larger codebase and it you can't pin down why it is
happening, please

  • Fork this StackBlitz template
  • Update it to the latest ng2-dragula
  • Modify it, and reproduce the issue
  • Add a link to it here.

Screenshots (optional)

If applicable, add screenshots to help explain your problem.

Versions (required)

Please state which versions of the following packages you have installed:

  • @angular/core: [e.g. 6.0.4]
  • ng2-dragula: [e.g. 2.0.0]

Browsers affected (optional)

Is this a bug in a particular browser? If so, it's unlikely that it's a problem with ng2-dragula. Instead, it is probably a bug in dragula.

Additional context (optional)

Add any other context about the problem here.

@ddn488
Copy link
Author

ddn488 commented May 3, 2024

The latest ng2-angular version 5.1.0 support up to 16.x. I have tried to install this version 5.1 and confirm it does not work with Angular 17. Please help a solution. Thanks

@ddn488 ddn488 changed the title ng2-dragula now working with Angular 17 - are you planning to support this feature? ng2-dragula version 5.1.0 NOT working with Angular 17 - are you planning to support this feature? May 3, 2024
@wslaghekke
Copy link

@ddn488 What issue are you having on Angular 17? I just upgraded and my application works just fine with Angular 17 + ng2-dragula 5.1.0

@joeskeen
Copy link
Contributor

joeskeen commented Jun 8, 2024

@ddn488 Please share the errors you are getting.

FYI I have created a StackBlitz example with ng2-dragula working with Angular 17:
https://stackblitz.com/edit/stackblitz-starters-og2a5k?file=src%2Fmain.ts


Edit: I have also created a StackBlitz example with ng2-dragula working with Angular 18:
https://stackblitz.com/edit/stackblitz-starters-krhdgm?file=src%2Fmain.ts
Note that since ng2-dragula explicitly forbids Angular >= 18, I had to add an overrides section to the package.json:

  "overrides": {
    "ng2-dragula": {
      "@angular/common": "$@angular/common",
      "@angular/core": "$@angular/core",
      "@angular/animations": "$@angular/animations"
    }
  }

@timmaguire
Copy link

@ddn488 Please share the errors you are getting.

FYI I have created a StackBlitz example with ng2-dragula working with Angular 17: https://stackblitz.com/edit/stackblitz-starters-og2a5k?file=src%2Fmain.ts

Edit: I have also created a StackBlitz example with ng2-dragula working with Angular 18: https://stackblitz.com/edit/stackblitz-starters-krhdgm?file=src%2Fmain.ts Note that since ng2-dragula explicitly forbids Angular >= 18, I had to add an overrides section to the package.json:

  "overrides": {
    "ng2-dragula": {
      "@angular/common": "$@angular/common",
      "@angular/core": "$@angular/core",
      "@angular/animations": "$@angular/animations"
    }
  }

Thanks for this tip, I didn't know there was an overrides section. Very helpful as we move to 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants