Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add persian localization #6011

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

MHKarami97
Copy link

No description provided.

@daniloff200
Copy link
Contributor

daniloff200 commented Jan 11, 2021

Hey! @MHKarami97 , thanks for your contribution!
I see that you added a file with locale, but, you also need to export it properly, and, add some tests

Here's examples of good PRs for other locales.

https://github.com/valor-software/ngx-bootstrap/pull/4969/files
https://github.com/valor-software/ngx-bootstrap/pull/4812/files

Could you please fix it?

@MHKarami97
Copy link
Author

@daniloff200
Ok, I do that, as soon as posible

@daniloff200
Copy link
Contributor

hi @MHKarami97 !
I've added couple of fixes to your PR, because, since January we changed the project structure a lot.
I also see, that some tests are failed. Unfortunately, I can't really understand what's going on there, because of Persian 😞 Could you look at it??

@cypress
Copy link

cypress bot commented Jul 29, 2021



Test summary

87 0 6 0


Run details

Project ngx-bootstrap
Status Passed
Commit 8dafd16
Started Sep 14, 2021 1:23 PM
Ended Sep 14, 2021 1:28 PM
Duration 04:20 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jul 29, 2021



Test summary

814 18 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 21c4300 ℹ️
Started Sep 14, 2021 1:22 PM
Ended Sep 14, 2021 1:35 PM
Duration 13:39 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale fa for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale fa for "Daterangepicker", container shown in this language
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Close" button, triggers the interceptor and doesn't close the modal
2 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Yes" button, closes the modal
3 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "No" button, doesn't close the modal
carousel_page_spec.ts Failed
1 Carousel page testing suite > Slide changed event > example contains slides, indicators, left and right controls and "Slide has been switched: 0"
2 Carousel page testing suite > Slide changed event > when user click on left arrow - info changed to "Slide has been switched: 2"
3 Carousel page testing suite > Slide changed event > when user click on left arrow again - info changed to "Slide has been switched: 1"
4 Carousel page testing suite > Slide changed event > when user click on right arrow - info changed to "Slide has been switched: 1"
5 Carousel page testing suite > Slide changed event > when user click on right arrow again - info changed to "Slide has been switched: 2"
This comment includes only the first 10 test failures. See all 18 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@SalehAhmadi
Copy link

Hi. Is there any updates on this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants