Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(collapse): respect display input value #6071

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix(collapse): respect display input value #6071

wants to merge 1 commit into from

Commits on Apr 24, 2021

  1. fix(collapse): respect display input value (valor-software#6070) 

    This change removes race conditions caused by TypeScript setters being called by Angular in non-deterministic order. Setters side effects (reading values set in other setters) are moved to ngOnChanges lifecycle hook. The consequence is that those side effects are no longer called when those inputs are set other than in the template. This is a breaking change but methods to call instead of setting those properties are already provided (show/hide) so migration path is straightforward. Setting display to 'none' no longer hides the collapse, setting collapse input to true or calling hide method is the way to go.

BREAKING CHANGE: setting display or collapse property on CollapseDirective no longer expands/collapses the collapse - use show/hide methods instead or set collapse input in template
    @marcinmajkowski
    marcinmajkowski committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    6a4ada2 View commit details
    Browse the repository at this point in the history