(launch, govern) feat: support mode network #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-atatakai
requested review from
mohandast52,
oaksprout and
truemiller
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
Tanya-atatakai
force-pushed
the
tanya/support-mode
branch
from
d64aa9c to
48a1695
Compare
Tanya-atatakai
commented
Oct 21, 2024
kupermind
reviewed
Oct 21, 2024
kupermind
approved these changes
Oct 21, 2024
DavidMinarsch
approved these changes
Oct 22, 2024
Tanya-atatakai
force-pushed
the
tanya/support-mode
branch
from
950fb99 to
575f146
Compare
|
bit overkill to define new chains with the same chainIds as the origin fork :/ |
truemiller
approved these changes
Oct 22, 2024
@truemiller good point actually, will consider changing that. but there's also something I'd like to discuss on our next eng call re this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support mode network on Govern and Launch. Tested on virtual test nets and forks, but with lots of troubles because of limitations.
Screen.Recording.2024-10-21.at.20.27.19.mov
Launch - nominated contract
Govern - Voting
Screen.Recording.2024-10-21.at.22.19.39.mov
Fixes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply