Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wormhole relayer for arbitrary msg.value-s #163

Merged
merged 7 commits into from
Nov 7, 2024
Merged

feat: wormhole relayer for arbitrary msg.value-s #163

merged 7 commits into from
Nov 7, 2024

Conversation

kupermind
Copy link
Collaborator

  • Wormhole relayer for arbitrary msg.value-s.

@kupermind
Copy link
Collaborator Author

This is the solution for any governance proposed message passing via Wormhole.

77ph
77ph previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@77ph 77ph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this idea. It makes sense to add reentrancy protection as usual.

77ph
77ph approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@77ph 77ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kupermind kupermind merged commit b8ca72b into main Nov 7, 2024
2 checks passed
@kupermind kupermind deleted the wormhole branch November 7, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@77ph 77ph 77ph approved these changes

@DavidMinarsch DavidMinarsch DavidMinarsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kupermind @DavidMinarsch @77ph