-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump [email protected] and get rid of the service delete workaround #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest open autonomy release includes a fix for superuser permission issue on the data generated by the tendermint node so we don't need the active paramter anymore
angrybayblade
commented
Feb 28, 2024
operate/services/_subgraph.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix included in the latest open-autonomy release, not required anymore
Comment on lines
-502
to
-509
try: | ||
shutil.rmtree(self.path) | ||
except (PermissionError, OSError): | ||
# If we get permission error we set the service in-active | ||
# user can then run operate prune with admin priviledges | ||
# to clean up the cache/unused data | ||
self.active = False | ||
self.store() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@truemiller the endpoint will delete the service completely
truemiller
approved these changes
Feb 28, 2024
Run formatters
0xArdi
pushed a commit
that referenced
this pull request
Oct 17, 2024
chore: Update service template hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.