Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: “Operating balance it too low” is shown on Trader agent, without being true. User gets 2 warning messages #601

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Dec 17, 2024

Proposed changes

  • Changed the Master EOA threshold to be 0.1 XDAI
  • Also, the alert should appear regardless of what the Master Safe has.

Balances

Scree2M Screenshot2

Alert

Screensh20 PM

If the EOA balance is below 0.1 👇

Screen3M

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 added the bug Something isn't working label Dec 17, 2024
@mohandast52 mohandast52 self-assigned this Dec 17, 2024
@mohandast52 mohandast52 merged commit a4d2030 into fix/meme-staging Dec 17, 2024
4 of 5 checks passed
@mohandast52 mohandast52 deleted the mohan/fix-low-balance-alert branch December 17, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants