From 72c3f26dd188cdb9291f14e03b6e6cbbcdee0317 Mon Sep 17 00:00:00 2001 From: David Minarsch Date: Tue, 21 Jun 2022 20:33:34 +0100 Subject: [PATCH] Apply suggestions from code review --- docs/gym-skill.md | 2 +- docs/http-connection-and-skill.md | 2 +- docs/ipfs_registry.md | 4 ++-- docs/multiplexer-standalone.md | 2 +- docs/p2p-connection.md | 4 ++-- docs/quickstart.md | 4 ++-- docs/registry.md | 2 +- tests/test_docs/test_bash_yaml/md_files/bash-gym-skill.md | 2 +- .../test_bash_yaml/md_files/bash-http-connection-and-skill.md | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/gym-skill.md b/docs/gym-skill.md index ee038b7f2c..d28712afc9 100644 --- a/docs/gym-skill.md +++ b/docs/gym-skill.md @@ -36,7 +36,7 @@ cd my_gym_aea ### Add the gym skill ``` bash -aea add skill fetchai/gym:0.20.0:QmdQisuqLhq81NHuas9ALYgP1tw1cZoE3vGueREgG8PgCZ +aea add skill fetchai/gym:0.20.0:QmdQisuqLhq81NHuas9ALYgP1tw1cZoE3vGueREgG8PgCZ --remote ``` ### Set gym connection as default diff --git a/docs/http-connection-and-skill.md b/docs/http-connection-and-skill.md index 80ff9f6f09..1fbc2aecfc 100644 --- a/docs/http-connection-and-skill.md +++ b/docs/http-connection-and-skill.md @@ -26,7 +26,7 @@ cd my_aea Add the http server connection package: ``` bash -aea add connection fetchai/http_server:0.22.0:Qmdr2Ajx5BRBJCC6xP8wUNSCMbhStHHZaVgzkoSW6Pvu7S +aea add connection fetchai/http_server:0.22.0:Qmdr2Ajx5BRBJCC6xP8wUNSCMbhStHHZaVgzkoSW6Pvu7S --remote ``` Update the default connection: diff --git a/docs/ipfs_registry.md b/docs/ipfs_registry.md index 7bd532502f..2ee57ab732 100644 --- a/docs/ipfs_registry.md +++ b/docs/ipfs_registry.md @@ -38,11 +38,11 @@ Packages can be downloaded using both extended public ids and hashes Add the signing protocol using -`aea add protocol QmWdCAiXpeT1tgrcf8uofKdQ6fLxMH77D5jwgQbbMo41df` +`aea add protocol QmWdCAiXpeT1tgrcf8uofKdQ6fLxMH77D5jwgQbbMo41df --remote` Or -`aea add protocol open_aea/signing:1.0.0:QmWdCAiXpeT1tgrcf8uofKdQ6fLxMH77D5jwgQbbMo41df` +`aea add protocol open_aea/signing:1.0.0:QmWdCAiXpeT1tgrcf8uofKdQ6fLxMH77D5jwgQbbMo41df --remote` ## Publishing agents diff --git a/docs/multiplexer-standalone.md b/docs/multiplexer-standalone.md index af8ca8106d..40f8787f82 100644 --- a/docs/multiplexer-standalone.md +++ b/docs/multiplexer-standalone.md @@ -1,6 +1,6 @@ The `Multiplexer` can be used stand-alone. This way a developer can utilise the protocols and connections independent of the `Agent` or `AEA` classes. -First, import the Python and application specific libraries and set the static variables. (Get the packages directory from the AEA repository `aea fetch PUBLIC_ID_OR_HASH`.) +First, import the Python and application specific libraries and set the static variables. (Get the packages directory from the AEA repository `svn export https://github.com/valory-xyz/open-aea.git/trunk/packages`.) ``` python import os import time diff --git a/docs/p2p-connection.md b/docs/p2p-connection.md index 1187004ace..8b3a2d3670 100644 --- a/docs/p2p-connection.md +++ b/docs/p2p-connection.md @@ -26,7 +26,7 @@ Create one AEA as follows: ``` bash aea create my_genesis_aea cd my_genesis_aea -aea add connection valory/p2p_libp2p:0.1.0:QmYW7Q5iFN6RwWmHj7wvjUBZfxu3hJN4KvcTWW1AhdKhki +aea add connection valory/p2p_libp2p:0.1.0:QmYW7Q5iFN6RwWmHj7wvjUBZfxu3hJN4KvcTWW1AhdKhki --remote aea config set agent.default_connection valory/p2p_libp2p:0.1.0 aea install aea build @@ -58,7 +58,7 @@ Create a second AEA: ``` bash aea create my_other_aea cd my_other_aea -aea add connection valory/p2p_libp2p:0.1.0:QmYW7Q5iFN6RwWmHj7wvjUBZfxu3hJN4KvcTWW1AhdKhki +aea add connection valory/p2p_libp2p:0.1.0:QmYW7Q5iFN6RwWmHj7wvjUBZfxu3hJN4KvcTWW1AhdKhki --remote aea config set agent.default_connection valory/p2p_libp2p:0.1.0 aea install aea build diff --git a/docs/quickstart.md b/docs/quickstart.md index 87a00ec5db..d393c998d2 100644 --- a/docs/quickstart.md +++ b/docs/quickstart.md @@ -255,14 +255,14 @@ cd my_first_aea
Second, add the stub connection to the project. ``` bash -aea add connection fetchai/stub:0.21.0:QmektTWmXcjThQd8md8nSYgLapR3Gks3n3WEzwAWQFgc4z +aea add connection fetchai/stub:0.21.0:QmektTWmXcjThQd8md8nSYgLapR3Gks3n3WEzwAWQFgc4z --remote ```
Add the echo skill
Third, add the echo skill to the project. ``` bash -aea add skill fetchai/echo:0.19.0:QmReV2qgjE4mkY9n5iwJDoEcv174Sxbjhxo84YZpLyvcR2 +aea add skill fetchai/echo:0.19.0:QmReV2qgjE4mkY9n5iwJDoEcv174Sxbjhxo84YZpLyvcR2 --remote ``` This copies the fetchai/echo:0.19.0 skill code containing the "behaviours", and "handlers" into the project, ready to run. The identifier of the skill fetchai/echo:0.19.0 consists of the name of the author of the skill, followed by the skill name and its version. diff --git a/docs/registry.md b/docs/registry.md index b12f22c4b3..fd9f1c8c63 100644 --- a/docs/registry.md +++ b/docs/registry.md @@ -22,7 +22,7 @@ Successfully added protocol 'open_aea/signing:1.0.0'. Once we have an agent, we can add individual components to the agent as so; ``` -aea add skill fetchai/echo:0.19.0:QmReV2qgjE4mkY9n5iwJDoEcv174Sxbjhxo84YZpLyvcR2 +aea add skill fetchai/echo:0.19.0:QmReV2qgjE4mkY9n5iwJDoEcv174Sxbjhxo84YZpLyvcR2 --remote Registry path not provided and local registry `packages` not found in current (.) and parent directory. Trying remote registry (`--remote`). Adding skill 'fetchai/echo:latest'... diff --git a/tests/test_docs/test_bash_yaml/md_files/bash-gym-skill.md b/tests/test_docs/test_bash_yaml/md_files/bash-gym-skill.md index f1a6693a7a..8e5d9d6e0c 100644 --- a/tests/test_docs/test_bash_yaml/md_files/bash-gym-skill.md +++ b/tests/test_docs/test_bash_yaml/md_files/bash-gym-skill.md @@ -8,7 +8,7 @@ aea create my_gym_aea cd my_gym_aea ``` ``` bash -aea add skill fetchai/gym:0.20.0:QmdQisuqLhq81NHuas9ALYgP1tw1cZoE3vGueREgG8PgCZ +aea add skill fetchai/gym:0.20.0:QmdQisuqLhq81NHuas9ALYgP1tw1cZoE3vGueREgG8PgCZ --remote ``` ``` bash aea config set agent.default_connection fetchai/gym:0.19.0 diff --git a/tests/test_docs/test_bash_yaml/md_files/bash-http-connection-and-skill.md b/tests/test_docs/test_bash_yaml/md_files/bash-http-connection-and-skill.md index 290cbf07f6..f68af4b575 100644 --- a/tests/test_docs/test_bash_yaml/md_files/bash-http-connection-and-skill.md +++ b/tests/test_docs/test_bash_yaml/md_files/bash-http-connection-and-skill.md @@ -3,7 +3,7 @@ aea create my_aea cd my_aea ``` ``` bash -aea add connection fetchai/http_server:0.22.0:Qmdr2Ajx5BRBJCC6xP8wUNSCMbhStHHZaVgzkoSW6Pvu7S +aea add connection fetchai/http_server:0.22.0:Qmdr2Ajx5BRBJCC6xP8wUNSCMbhStHHZaVgzkoSW6Pvu7S --remote ``` ``` bash aea config set agent.default_connection fetchai/http_server:0.22.0