From 112fa9284296c94fbd137a21ab7340922dfd9185 Mon Sep 17 00:00:00 2001 From: DivyaNautiyal07 Date: Fri, 21 Feb 2025 22:20:14 +0530 Subject: [PATCH] fix: add error handling --- packages/packages.json | 8 ++++---- packages/valory/agents/optimus/aea-config.yaml | 4 ++-- packages/valory/services/optimus/service.yaml | 2 +- .../skills/liquidity_trader_abci/behaviours.py | 13 +++++++++---- .../valory/skills/liquidity_trader_abci/skill.yaml | 2 +- packages/valory/skills/optimus_abci/skill.yaml | 2 +- 6 files changed, 18 insertions(+), 13 deletions(-) diff --git a/packages/packages.json b/packages/packages.json index 4166bde1..ea782a74 100644 --- a/packages/packages.json +++ b/packages/packages.json @@ -14,10 +14,10 @@ "contract/valory/staking_token/0.1.0": "bafybeiev3fx5wg4rs5rciqdxemdvt73fwu2nylv23i7g665jzorcyyjape", "contract/valory/staking_activity_checker/0.1.0": "bafybeigse23vkx6rxws7ydkl44gtqs5z2g7fo4qejb36pjznegkbv5tkeu", "contract/valory/sturdy_yearn_v3_vault/0.1.0": "bafybeid4krjmfca3dert6tackcut2tins24kunzfwxs4gu3zgdhzrkijkm", - "skill/valory/liquidity_trader_abci/0.1.0": "bafybeiht3y5lzgrkl252sy2zso3lmbi2hfqdtgp5eunljy2vxramsowiuu", - "skill/valory/optimus_abci/0.1.0": "bafybeih7pzvdnk3pgepdhl5cvye6vl5ovutymwniex7czi442qge4cle4i", - "agent/valory/optimus/0.1.0": "bafybeiehzxh5waqkg5fil4mf2q4rtcuobz5nleu6bsxppv3bfgplfmru24", - "service/valory/optimus/0.1.0": "bafybeiefa2tf22ydibphyetj6ahpo75nz43bxrnktgjwwgjumfd2opbyfy" + "skill/valory/liquidity_trader_abci/0.1.0": "bafybeignfokroe4tc3wwuv3zs6pxer7mogiwoofdzidfbejylop6dg5swe", + "skill/valory/optimus_abci/0.1.0": "bafybeiaoay3i6jjiteteyensjzaoom527wwg4sintyjksg6vk5xo32vsh4", + "agent/valory/optimus/0.1.0": "bafybeidqyhrfwlxpton6sfxfvc3js7ehy5m4taujf7doo7azgdbfdkx6he", + "service/valory/optimus/0.1.0": "bafybeicbj34v3buesttyht4f47b3qytwztdrqpanwpi2qa7oq46lwk632y" }, "third_party": { "protocol/open_aea/signing/1.0.0": "bafybeig2d36zxy65vd7fwhs7scotuktydcarm74aprmrb5nioiymr3yixm", diff --git a/packages/valory/agents/optimus/aea-config.yaml b/packages/valory/agents/optimus/aea-config.yaml index 78126e69..93c10ab6 100644 --- a/packages/valory/agents/optimus/aea-config.yaml +++ b/packages/valory/agents/optimus/aea-config.yaml @@ -36,8 +36,8 @@ protocols: skills: - valory/abstract_abci:0.1.0:bafybeia2egqettv7fd4yryya5ocrxdmpxibvt5ayjg2npvblz73rjpoxla - valory/abstract_round_abci:0.1.0:bafybeia27qmw6w5ds5fcrpj2475brnz742aampe3sgochloijs2l7jovai -- valory/liquidity_trader_abci:0.1.0:bafybeiht3y5lzgrkl252sy2zso3lmbi2hfqdtgp5eunljy2vxramsowiuu -- valory/optimus_abci:0.1.0:bafybeih7pzvdnk3pgepdhl5cvye6vl5ovutymwniex7czi442qge4cle4i +- valory/liquidity_trader_abci:0.1.0:bafybeignfokroe4tc3wwuv3zs6pxer7mogiwoofdzidfbejylop6dg5swe +- valory/optimus_abci:0.1.0:bafybeiaoay3i6jjiteteyensjzaoom527wwg4sintyjksg6vk5xo32vsh4 - valory/registration_abci:0.1.0:bafybeifaa6ejpihwxxxswqd5qfy63rixml43d3ljnezilflvdtclspjj6y - valory/reset_pause_abci:0.1.0:bafybeigebq46oqz2mx2iajupr6p5pgm6z5pvfye5w6zypsseuqtvta7b4a - valory/termination_abci:0.1.0:bafybeieurwmfernodqyczj5ertsgfbjtjnrlgvte7sli4sajnbopty7inu diff --git a/packages/valory/services/optimus/service.yaml b/packages/valory/services/optimus/service.yaml index 0fca424f..c285aabb 100644 --- a/packages/valory/services/optimus/service.yaml +++ b/packages/valory/services/optimus/service.yaml @@ -6,7 +6,7 @@ aea_version: '>=1.0.0, <2.0.0' license: Apache-2.0 fingerprint: {} fingerprint_ignore_patterns: [] -agent: valory/optimus:0.1.0:bafybeiehzxh5waqkg5fil4mf2q4rtcuobz5nleu6bsxppv3bfgplfmru24 +agent: valory/optimus:0.1.0:bafybeidqyhrfwlxpton6sfxfvc3js7ehy5m4taujf7doo7azgdbfdkx6he number_of_agents: 1 deployment: agent: diff --git a/packages/valory/skills/liquidity_trader_abci/behaviours.py b/packages/valory/skills/liquidity_trader_abci/behaviours.py index fde13cfe..8a77d34c 100644 --- a/packages/valory/skills/liquidity_trader_abci/behaviours.py +++ b/packages/valory/skills/liquidity_trader_abci/behaviours.py @@ -3813,10 +3813,15 @@ def _get_step_transaction( ) if response.status_code not in HTTP_OK: - response = json.loads(response.body) - self.context.logger.error( - f"[LiFi API Error Message] Error encountered: {response['message']}" - ) + try: + response_data = json.loads(response.body) + self.context.logger.error( + f"[LiFi API Error Message] Error encountered: {response_data['message']}" + ) + except (ValueError, TypeError) as e: + self.context.logger.error( + f"Could not parse error response from API: {e}\nResponse body: {response.body}" + ) return None try: diff --git a/packages/valory/skills/liquidity_trader_abci/skill.yaml b/packages/valory/skills/liquidity_trader_abci/skill.yaml index 3dd8e437..897e0b85 100644 --- a/packages/valory/skills/liquidity_trader_abci/skill.yaml +++ b/packages/valory/skills/liquidity_trader_abci/skill.yaml @@ -7,7 +7,7 @@ license: Apache-2.0 aea_version: '>=1.0.0, <2.0.0' fingerprint: __init__.py: bafybeia7bn2ahqqwkf63ptje6rfnftuwrsp33sswgpcbh5osbesxxr6g4m - behaviours.py: bafybeihk7bnbtrgnrhyoke5hcoqya5vtt4m6oypuluvklviko6rk64cqtm + behaviours.py: bafybeie5paomtboiyobkatv5ygfbkshhukiykiw6jhykrwgbgwokkxbjgu dialogues.py: bafybeiay23otskx2go5xhtgdwfw2kd6rxd62sxxdu3njv7hageorl5zxzm fsm_specification.yaml: bafybeie3vom7fwl5ho6xanje3r7tab7y3a5ij5gs6qvjh2uavbpitffyzu handlers.py: bafybeih2zlmkyntlr7zx4mokqkmpcw7qczfbo47g766kndbv7zv7oqjv6e diff --git a/packages/valory/skills/optimus_abci/skill.yaml b/packages/valory/skills/optimus_abci/skill.yaml index 8fe01cec..848cfc29 100644 --- a/packages/valory/skills/optimus_abci/skill.yaml +++ b/packages/valory/skills/optimus_abci/skill.yaml @@ -24,7 +24,7 @@ skills: - valory/registration_abci:0.1.0:bafybeifaa6ejpihwxxxswqd5qfy63rixml43d3ljnezilflvdtclspjj6y - valory/reset_pause_abci:0.1.0:bafybeigebq46oqz2mx2iajupr6p5pgm6z5pvfye5w6zypsseuqtvta7b4a - valory/termination_abci:0.1.0:bafybeieurwmfernodqyczj5ertsgfbjtjnrlgvte7sli4sajnbopty7inu -- valory/liquidity_trader_abci:0.1.0:bafybeiht3y5lzgrkl252sy2zso3lmbi2hfqdtgp5eunljy2vxramsowiuu +- valory/liquidity_trader_abci:0.1.0:bafybeignfokroe4tc3wwuv3zs6pxer7mogiwoofdzidfbejylop6dg5swe - valory/transaction_settlement_abci:0.1.0:bafybeifkftgkyzrxwxjdyqixpp7vk6aqmufikalmwx3kydtlg74tonu47u behaviours: main: