-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Polymarket support #195
base: develop
Are you sure you want to change the base?
Conversation
# Conflicts: # packages/packages.json # packages/valory/agents/trader/aea-config.yaml # packages/valory/services/trader/service.yaml # packages/valory/skills/decision_maker_abci/behaviours/sampling.py # packages/valory/skills/decision_maker_abci/skill.yaml # packages/valory/skills/market_manager_abci/skill.yaml # packages/valory/skills/trader_abci/skill.yaml # packages/valory/skills/tx_settlement_multiplexer_abci/skill.yaml
[no ci]
# get only bets that close in the next 48 hours | ||
# get only bets that close in the next `sample_bets_closing_days` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample_bets_closing_days
override can be set to a large value to test kelly for Polymarket.
# TODO: we ignore 'creators' and simply fetch 100 latest markets. | ||
query = questions_polymarket_gamma.substitute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
AND created_by=$creator
to the "where:" query parameter on polymarket_gamma query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It cannot be addressed this way since we do not know the creators in advance. Instead, fetching all the markets and adding pagination might make more sense.
} | ||
|
||
return cls( | ||
collateralToken=USDC, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: make sure collateralToken
is not used when making a request to the mech, but xdai or wxdai is used.
Note: we need to interact with both gnosis and polygon chains for Polymarket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to interact with both chains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To interact with the mech on Gnosis. Is the mech deployed on Polygon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will deploy it on Polygon eventually. For testing use it on Gnosis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is only for testing then it would be faster to test this by mocking the mech request-response part locally and keep the code unchanged for when the mech is deployed on Polygon.
575f02d
to
d698fc7
Compare
Polymarket support