Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadTimeout is not unset when connection is forwarded to the NextProtos. #1080

Closed
dgrr opened this issue Aug 27, 2021 · 2 comments · Fixed by #1081
Closed

ReadTimeout is not unset when connection is forwarded to the NextProtos. #1080

dgrr opened this issue Aug 27, 2021 · 2 comments · Fixed by #1081
Labels
pending/submitter-response

Comments

@dgrr
Copy link
Contributor

dgrr commented Aug 27, 2021

The SetReadDeadline is not unset after the proto returns correctly here.
Related to this issue
@erikdubbelboer erikdubbelboer mentioned this issue Aug 27, 2021
Merged
@erikdubbelboer
Copy link
Collaborator

@dgrr check #1081 I fixed various other deadline fixes as well.

@dgrr
Copy link
Contributor Author

dgrr commented Aug 28, 2021

Ok. The comment makes sense. You can close this issue after merging that commit if you want. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending/submitter-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various deadline fixes valyala/fasthttp
2 participants
@erikdubbelboer @dgrr