Add '--ignore-engines' flag to 'yarn install' in dockerfile to avoid engine incompatability error #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void engine incompatability error
|
@0xpetersatoshi is attempting to deploy a commit to the vana Team on Vercel. To accomplish this, @0xpetersatoshi needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
This PR resolves #109 by adding the
--ignore-enginesflag toyarn installin thedevelopment.dockerfile. Without this flag, running a script that builds the docker image throws an error related to a node engine incompatibility issue. The updated behavior is that the docker image is built without errors.Other changes
Describe any minor or "drive-by" changes here.
N/A
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
In addition to pre-commit and push unit tests passing successfully, this was tested by running the
./scripts/dc-start-vault-guiscript from the development-stack directory which starts the vault-gui app. Then, the app was accessed on http://localhost:5000/ and data was uploaded successfully to the vault.Related issues
yarn installstep #109Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.
N/A