Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve webmention types #6

Open
vandie opened this issue Jul 21, 2022 · 2 comments
Open

Improve webmention types #6

vandie opened this issue Jul 21, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
0.1.0

Comments

@vandie
Copy link
Owner

vandie commented Jul 21, 2022

At the moment all mentions are stored as the type Mention, it would be nice to have Types for the different mention structures (Reply, Like etc.) with the regular Mention acting as a fallback. This might require a lot of optional fields but I think it would help people implementing the library for the first time.
@vandie vandie added chore Something that needs to be done but doesn't add anything new or fix any bugs enhancement New feature or request and removed chore Something that needs to be done but doesn't add anything new or fix any bugs labels Jul 21, 2022
@vandie vandie added this to the 0.1.0 milestone Jul 21, 2022
@vandie
Copy link
Owner Author

vandie commented Aug 1, 2022

New branch for these created (here) Will create a PR once the major types are covered

@vandie
Copy link
Owner Author

vandie commented Nov 11, 2023

I think if we decide to implement #20 then this will be resolved as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@vandie