Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite: Fix CSS output not updating in watch mode #1397

Merged
merged 1 commit into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-ligers-act.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@vanilla-extract/vite-plugin': patch
---

Fixes a bug that was causing output CSS files to not update during watch mode
9 changes: 8 additions & 1 deletion packages/vite-plugin/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,14 @@ export function vanillaExtractPlugin({
}
},
buildEnd() {
compiler?.close();
// When using the rollup watcher, we don't want to close the compiler after every build.
// Instead, we close it when the watcher is closed via the closeWatcher hook.
if (!config.build.watch) {
compiler?.close();
}
},
closeWatcher() {
return compiler?.close();
},
async transform(code, id) {
const [validId] = id.split('?');
Expand Down
Loading