Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin): Omit React-Router v7 plugin for DevServer #1492

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

kube
Copy link
Contributor

@kube kube commented Oct 20, 2024

Similar to #1308.

Omit React-Router plugin for DevServer in Vanilla-Extract Vite plugin, as React-Router plugin throws when launched without Configuration file. (just like the Remix plugin)

Copy link

changeset-bot bot commented Oct 20, 2024

🦋 Changeset detected

Latest commit: ff1e357

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vanilla-extract/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kube kube changed the title fix(VitePlugin): Omit React-Router plugin for DevServer fix(vite-plugin): Omit React-Router plugin for DevServer Oct 20, 2024
@kube
Copy link
Contributor Author

kube commented Oct 21, 2024

@askoufis this is a simple one and will enable compatibility with React Router 7.

@kube kube changed the title fix(vite-plugin): Omit React-Router plugin for DevServer fix(vite-plugin): Omit React-Router v7 plugin for DevServer Oct 21, 2024
Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@askoufis askoufis enabled auto-merge (squash) October 23, 2024 22:59
@askoufis askoufis disabled auto-merge October 23, 2024 23:04
@askoufis
Copy link
Contributor

@kube Could you run the format script? Will merge after that's done.

@kube
Copy link
Contributor Author

kube commented Oct 24, 2024

@askoufis Done.

@kube kube requested a review from askoufis October 24, 2024 22:10
@askoufis askoufis merged commit 1fd348a into vanilla-extract-css:master Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants