Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Audio Clicking Fix #84

Open
Hellsing666 opened this issue Aug 29, 2021 · 4 comments
Open

Possible Audio Clicking Fix #84

Hellsing666 opened this issue Aug 29, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@Hellsing666
Copy link

I know this is a copy of #52. But I wanted ask that if you changed something in the mute silence feature in version 3.4.2. Cause when I play videos using version 3.4.1(Unpacked), there is no audio clicking problem at all, but 3.4.2 causes the clicking issue. Subsequently the problem exists in version 4.0.0. Maybe you wanna look into it?

@WofWca
Copy link

WofWca commented Aug 29, 2021

There are no relevant changes at all: 3.4.1...3.4.2

Perhaps settings are different between the two installations of the extension?

@Hellsing666
Copy link
Author

Maybe the change is in version 4.0.0. The clicking issue is much more prevalent when I compare it with version 3.4.1 side by side.

@vantezzen
Copy link
Owner

Thank you for the bug report.
3.4.2 was only a small update to support Firefox so there weren't any script changes, but it might be 4.0.0 which refactored some code.

Just to confirm:

  • 3.4.1: No clicking problem when "Mute silence" is active
  • 3.4.2 and 4.0.0: Clicking, even when "Mute silence" is enabled
    correct?

So I can debug this issue, can you provide this info:

  • Your Browser and browser version (open about:version)
  • Your OS and it's version
  • Optionally a demo video/website that you encounter the clicking on?

@vantezzen vantezzen added the bug Something isn't working label Aug 29, 2021
@Hellsing666
Copy link
Author

Yes, Correct.

I used 3.4.2 on firefox 91.0.1.
3.4.1 and 4.0.0 on edge 92.0.902.73.

Os: windows 10 (1909).

For demo you can play this YouTube video comparing the extensions side by side:
https://www.youtube.com/watch?v=ERubPPOaEp0&t=12

The clicking issue is more apparent in the order
4.0.0>>3.4.2>3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants