Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a way to make this compatible with Vapor 4/SPM? #6

Open
geeksweep opened this issue Feb 26, 2020 · 3 comments
Open

Is there a way to make this compatible with Vapor 4/SPM? #6

geeksweep opened this issue Feb 26, 2020 · 3 comments

Comments

@geeksweep
Copy link

Been talking with @anthonycastelli about this , going through Vapor 3 issues. Wondering if anyone can take on converting this to Vapor 4/SPM?
@geeksweep
Copy link
Author

@anthonycastelli

@charlymr
Copy link

@geeksweep Hello if you are still interested, I removed all dependencies in my version, making it usable anywhere.
https://github.com/charlymr/onesignal

@0xTim
Copy link
Member

0xTim commented Jun 16, 2021

Just a heads up, URLSession is not advised for a server app - it doesn't play nice with futures or concurrency etc though is better than something that won't compile!

The canonical way would be to build this on top of AsyncHTTPClient and SwiftNIO if anyone wants to do the port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@charlymr @geeksweep @0xTim