Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Clear file' should preserve the BOM if any #132

Open
wiz0u opened this issue Nov 15, 2019 · 4 comments
Open

'Clear file' should preserve the BOM if any #132

wiz0u opened this issue Nov 15, 2019 · 4 comments

Comments

@wiz0u
Copy link

wiz0u commented Nov 15, 2019

When viewing a file that has an explicit BOM, clearing the file should not truncate it to 0 bytes but should preserve the BOM.

Additionally, please add a '...' at the end of the "Clear file" menu caption to clearly show that there will be a confirmation dialog before proceeding.

@variar
Copy link
Owner

variar commented Nov 15, 2019

BOM should be put by whatever is writing to log file. It is not intuitive that in some cases "clear" does leave behind some stuff

@wiz0u
Copy link
Author

wiz0u commented Nov 18, 2019

The writer program logic might be "if file is absent, create and write BOM, and then append the logs" and "if file is present, just append the logs"
So an actual zero-bytes file might confuse the system.

@variar
Copy link
Owner

variar commented Dec 30, 2019

Looks like we need a checkbox in Advanced settings tab for configuring this.

@wiz0u
Copy link
Author

wiz0u commented Dec 30, 2019

Looks like we need a checkbox in Advanced settings tab for configuring this.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants