Skip to content

Commit

Permalink
params: Restrict some session timeouts
Browse files Browse the repository at this point in the history
The timeout_* parameters are used in duration arithmetics and the
simplest is to not grant them the ability to be disabled.

Both timeout_idle and idle_send_timeout appear in a CondWait context.
For this reason both need to be capped to 1h, matching the implicit
limit in Lck_CondWaitTimeout().
  • Loading branch information
dridi committed Mar 5, 2024
1 parent a26123f commit 460b9ce
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions include/tbl/params.h
Original file line number Diff line number Diff line change
Expand Up @@ -643,9 +643,9 @@ PARAM_SIMPLE(
PARAM_SIMPLE(
/* name */ idle_send_timeout,
/* type */ timeout,
/* min */ "0.000",
/* max */ NULL,
/* def */ "60.000",
/* min */ "0s",
/* max */ "1h",
/* def */ "60s",
/* units */ "seconds",
/* descr */
"Send timeout for individual pieces of data on client connections."
Expand Down Expand Up @@ -946,10 +946,10 @@ PARAM_SIMPLE(

PARAM_SIMPLE(
/* name */ timeout_idle,
/* type */ timeout,
/* min */ "0.000",
/* max */ NULL,
/* def */ "5.000",
/* type */ duration,
/* min */ "0s",
/* max */ "1h",
/* def */ "5s",
/* units */ "seconds",
/* descr */
"Idle timeout for client connections.\n\n"
Expand All @@ -962,7 +962,7 @@ PARAM_SIMPLE(

PARAM_SIMPLE(
/* name */ timeout_linger,
/* type */ timeout,
/* type */ duration,
/* min */ "0.000",
/* max */ NULL,
/* def */ "0.050",
Expand Down

0 comments on commit 460b9ce

Please sign in to comment.