Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrt: Fail the transaction for all out of workspace conditions #3769

Open
dridi opened this issue Jan 5, 2022 · 1 comment
Open

vrt: Fail the transaction for all out of workspace conditions #3769

dridi opened this issue Jan 5, 2022 · 1 comment

Comments

@dridi
Copy link
Member

dridi commented Jan 5, 2022

See #3765 (comment).

Most VRT functions to convert VCL types to STRING ignore workspace overflows. If they failed, that would become very problematic in vcl_synth where even static assignments of headers would simply fail. This is handled in #3768, and this ticket is here to make sure we review workspace usage in VRT and maybe fail where we currently don't (or document in the code why we wouldn't).

@dridi
Copy link
Member Author

dridi commented Jul 25, 2022

I initially didn't see the link between this ticket and #3825, but the two should be linked. Both are very broad, and there is some overlap, but #3825 is sort of equivalent for all http_*() failures and not limited to workspace overflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant