From e382bc1a3038a5bd87f1355143f6cf7ff87cf7f5 Mon Sep 17 00:00:00 2001
From: Joris-k <joris.kosacki@vates.tech>
Date: Wed, 4 Dec 2024 16:18:11 +0100
Subject: [PATCH] review feedback

---
 .../pool/network/PoolNetworksPifStatus.vue    | 20 ++++++++++---------
 .../pool/network/PoolNetworksTable.vue        |  2 +-
 @xen-orchestra/lite/src/locales/en.json       |  3 +++
 @xen-orchestra/lite/src/locales/fr.json       |  5 ++++-
 .../lite/src/stores/xen-api/network.store.ts  |  4 +---
 5 files changed, 20 insertions(+), 14 deletions(-)

diff --git a/@xen-orchestra/lite/src/components/pool/network/PoolNetworksPifStatus.vue b/@xen-orchestra/lite/src/components/pool/network/PoolNetworksPifStatus.vue
index e26d69e5dd8..727dfffef3e 100644
--- a/@xen-orchestra/lite/src/components/pool/network/PoolNetworksPifStatus.vue
+++ b/@xen-orchestra/lite/src/components/pool/network/PoolNetworksPifStatus.vue
@@ -1,24 +1,26 @@
 <template>
-  <UiInfo class="text-ellipsis" :accent="statusProps.accent">
-    <span class="text-ellipsis">{{ statusProps.text }}</span>
+  <UiInfo :accent="statusProps.accent">
+    <span>{{ statusProps.text }}</span>
   </UiInfo>
 </template>
 
 <script setup lang="ts">
 import UiInfo from '@core/components/ui/info/UiInfo.vue'
 import { computed } from 'vue'
+import { useI18n } from 'vue-i18n'
 
-const { pif } = defineProps<{
-  pif: { status: 'connected' | 'disconnected' | 'partially_connected' }
+const { status } = defineProps<{
+  status: 'connected' | 'disconnected' | 'partial'
 }>()
 
+const { t } = useI18n()
+
 type NetworkAccent = 'success' | 'warning' | 'danger'
 
 const statusMap: Record<string, { text: string; accent: NetworkAccent }> = {
-  connected: { text: 'Connected', accent: 'success' },
-  disconnected: { text: 'Disconnected', accent: 'danger' },
-  partially_connected: { text: 'Partially Connected', accent: 'warning' },
+  connected: { text: t('connected'), accent: 'success' },
+  disconnected: { text: t('disconnected'), accent: 'danger' },
+  partial: { text: t('partially-connected'), accent: 'warning' },
 }
-
-const statusProps = computed(() => statusMap[pif.status])
+const statusProps = computed(() => statusMap[status])
 </script>
diff --git a/@xen-orchestra/lite/src/components/pool/network/PoolNetworksTable.vue b/@xen-orchestra/lite/src/components/pool/network/PoolNetworksTable.vue
index 6b7982f903a..3e75b0c5add 100644
--- a/@xen-orchestra/lite/src/components/pool/network/PoolNetworksTable.vue
+++ b/@xen-orchestra/lite/src/components/pool/network/PoolNetworksTable.vue
@@ -54,7 +54,7 @@
                   {{ (row.value as any).network.name_description }}
                 </div>
                 <div v-if="column.id === 'status'" class="status">
-                  <PoolNetworksPifStatus :pif="row.value" />
+                  <PoolNetworksPifStatus :status="(row.value as any).status" />
                 </div>
                 <div v-if="column.id === 'vlan'" v-tooltip="{ placement: 'bottom-end' }" class="text-ellipsis">
                   {{ (row.value as any).vlan }}
diff --git a/@xen-orchestra/lite/src/locales/en.json b/@xen-orchestra/lite/src/locales/en.json
index 637bd240df8..f83534db052 100644
--- a/@xen-orchestra/lite/src/locales/en.json
+++ b/@xen-orchestra/lite/src/locales/en.json
@@ -33,6 +33,7 @@
   "close": "Close",
   "community": "Community",
   "community-name": "{name} community",
+  "connected": "Connected",
   "configuration": "Configuration",
   "confirm-cancel": "Are you sure you want to cancel?",
   "confirm-delete": "You're about to delete {0}",
@@ -58,6 +59,7 @@
   "description": "Description",
   "dhcp": "DHCP",
   "disabled": "Disabled",
+  "disconnected": "Disconnected",
   "display": "Display",
   "dns": "DNS",
   "do-you-have-needs": "You have needs and/or expectations? Let us know",
@@ -197,6 +199,7 @@
   "ok": "OK",
   "on-object": "on {object}",
   "or": "Or",
+  "partially-connected": "Partially connected",
   "password": "Password",
   "password-invalid": "Password invalid",
   "pause": "Pause",
diff --git a/@xen-orchestra/lite/src/locales/fr.json b/@xen-orchestra/lite/src/locales/fr.json
index bec38f35785..767ae699bcf 100644
--- a/@xen-orchestra/lite/src/locales/fr.json
+++ b/@xen-orchestra/lite/src/locales/fr.json
@@ -33,6 +33,7 @@
   "close": "Fermer",
   "community": "Communauté",
   "community-name": "Communauté {name}",
+  "connected": "Connecté",
   "configuration": "Configuration",
   "confirm-cancel": "Êtes-vous sûr de vouloir annuler ?",
   "confirm-delete": "Vous êtes sur le point de supprimer {0}",
@@ -59,6 +60,7 @@
   "dhcp": "DHCP",
   "dns": "DNS",
   "disabled": "Désactivé",
+  "disconnected": "Déconnecté",
   "display": "Affichage",
   "do-you-have-needs": "Vous avez des besoins et/ou des attentes ? Faites le nous savoir",
   "documentation": "Documentation",
@@ -99,7 +101,7 @@
   "here": "Ici",
   "host.active": "Actif | Actif | Actifs",
   "host.inactive": "Inactif | Inactif | Inactifs",
-  "host-internal-networks": "Réseaux interne de l'hôte",
+  "host-internal-networks": "Réseaux internes de l'hôte",
   "invalid-field": "Champ invalide",
 
   "job.vm-copy.bad-power-state": "La VM doit être arrêtée",
@@ -197,6 +199,7 @@
   "ok": "OK",
   "on-object": "sur {object}",
   "or": "Ou",
+  "partially-connected": "Partiellement connecté",
   "password": "Mot de passe",
   "password-invalid": "Mot de passe incorrect",
   "pause": "Pause",
diff --git a/@xen-orchestra/lite/src/stores/xen-api/network.store.ts b/@xen-orchestra/lite/src/stores/xen-api/network.store.ts
index b1d4be5e37c..b7a232da1b6 100644
--- a/@xen-orchestra/lite/src/stores/xen-api/network.store.ts
+++ b/@xen-orchestra/lite/src/stores/xen-api/network.store.ts
@@ -70,9 +70,7 @@ export const useNetworkStore = defineStore('xen-api-network', () => {
   })
 
   const hostInternalNetworks = computed(() => {
-    return baseContext.records.value
-      .filter(network => network.PIFs.length === 0) // Only networks without PIFs
-      .map(network => network)
+    return baseContext.records.value.filter(network => network.PIFs.length === 0) // Only networks without PIFs
   })
 
   const context = {