sync roles once per day and fix the assign roles command to remove ro…

…les correctly

assign_roles.js

@@ -75,7 +75,7 @@ async function assignRoles(member) {
                 member.roles.add(discordRole).catch(e => console.log(e));
             }
         } else {
-            if (member.roles.cache.some(r => r.name === role)) {
+            if (member.roles.cache.some(r => r.name !== role)) {
                 member.roles.remove(discordRole).catch(e => console.log(e));
             }
         }

events/ready.js

@@ -1,20 +1,18 @@
 const {assignRoles} = require("../assign_roles.js");
-const { ActivityType } = require('discord.js');
+const {ActivityType} = require('discord.js');
+const cron = require('node-cron')
 module.exports = {
     name: 'ready',
     once: true,
     async execute(client) {
         console.log(`Logged in as ${client.user.tag}`);
-        client.user.setActivity('The VATSIM Network', { type: ActivityType.Watching })
-    setInterval(async function() {
-        const guild = client.guilds.cache.get("901078003482783765");
-        const members = await guild.members.fetch();
-        members.forEach(member =>
-           setInterval(function (){
-               assignRoles(member)
-           },500)
-        )
-        console.log("I have assigned everyone's roles");
-    },2*12*60*60*1000)
-    },
+        client.user.setActivity('The VATSIM Network', {type: ActivityType.Watching})
+        cron.schedule('30 02 * * *', async () => {
+            const guild = client.guilds.cache.get("901078003482783765");
+            const members = await guild.members.fetch();
+            members.forEach(member =>
+                assignRoles(member)
+            )
+        })
+    }
 };

package.json

@@ -2,6 +2,7 @@
   "dependencies": {
     "discord.js": "^14.11.0",
     "dotenv": "^16.0.3",
+    "node-cron": "^3.0.3",
     "nodemon": "^2.0.20",
     "p-limit": "^3.1.0"
   },