Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented JSONSchemaBridge breaking change in v4 #1360

Closed
Gwened opened this issue Jul 23, 2024 · 1 comment · Fixed by #1362
Closed

Undocumented JSONSchemaBridge breaking change in v4 #1360

Gwened opened this issue Jul 23, 2024 · 1 comment · Fixed by #1362
Assignees
@Monteth
Labels
Area: Bridge Affects some of the bridge packages Area: Docs Affects the documentation or reproductions seed Bridge: JSON Schema Affects the uniforms-bridge-json-schema package
Milestone
v4.0

Comments

@Gwened
Copy link

Gwened commented Jul 23, 2024

Migrating from v3 to v4:
Now the JSONSchemaBridge constructor takes an object: {schema, validator...} instead of two parameters.

Either the previous argument structure should remain supported, or this should be mentioned in the breaking changes of the documentation: https://uniforms.tools/docs/migrating-3-to-4/#breaking-api-changes

Version: 4.0.0-alpha.5
Package: uniforms-bridge-json-schema
Commit: 1c69877
@piotrpospiech piotrpospiech moved this to Needs triage in Open Source Jul 26, 2024
@Monteth Monteth mentioned this issue Aug 9, 2024
Merged
@Monteth
Copy link
Member

Monteth commented Aug 9, 2024

Hi @Gwened,
Thanks for pointing this out! We've updated the migration guide to mention constructor changes in all bridges. This change is included in PR #1362.

@kestarumper kestarumper added this to the v4.0 milestone Aug 23, 2024
@kestarumper kestarumper linked a pull request Aug 23, 2024 that will close this issue
Add bridge constructor changes to v4 migration guide. #1362
Merged
@kestarumper kestarumper added Area: Bridge Affects some of the bridge packages Area: Docs Affects the documentation or reproductions seed Bridge: JSON Schema Affects the uniforms-bridge-json-schema package labels Aug 23, 2024
@github-project-automation github-project-automation bot moved this from Review to Closed in Open Source Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Monteth Monteth

Labels
Area: Bridge Affects some of the bridge packages Area: Docs Affects the documentation or reproductions seed Bridge: JSON Schema Affects the uniforms-bridge-json-schema package
Projects
Open Source
Archived in project
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Add bridge constructor changes to v4 migration guide. vazco/uniforms
3 participants
@kestarumper @Monteth @Gwened