Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DappKit :: Adding options to the signTypedData #1367

Closed
Valazan opened this issue Oct 1, 2024 · 1 comment
Closed

DappKit :: Adding options to the signTypedData #1367

Valazan opened this issue Oct 1, 2024 · 1 comment

Comments

@Valazan
Copy link
Contributor

Valazan commented Oct 1, 2024

To enhance compatibility with extension and mobile and to allow account switching when signing typed data, we should add the following optional options parameter to the signTypedData:

interface SignTypedDataOptions {
  signer?: string;
}

async signTypedData(
    _domain: ethers.TypedDataDomain,
    _types: Record<string, ethers.TypedDataField[]>,
    _value: Record<string, unknown>,
    _options?: SignTypedDataOptions
  ): Promise<string>
@victhorbi
Copy link
Collaborator

I would like to keep this in the RC, since next week people may already start using it.

@victhorbi victhorbi added this to the RC milestone Oct 4, 2024
@fabiorigam fabiorigam assigned fabiorigam and unassigned Valazan Oct 8, 2024
@victhorbi victhorbi assigned Valazan and unassigned fabiorigam Oct 8, 2024
@fabiorigam fabiorigam linked a pull request Oct 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants