Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The role value should align with the roles in our documentation #194

Open
binarylogic opened this issue Apr 5, 2022 · 1 comment
Open

Comments

@binarylogic
Copy link

Currently the role value accepts Agent, Aggregator, and Stateless-Aggregator. If possible, we should update this to reflect the two roles that we are communicating in the docs: Agent and Aggregator. A stateful/stateless aggregator is just a type an aspect of the Aggregator role and should be controlled by a separate value (i.e., stateful or persistent_disk).

This is a small tweak but will help unify the experience across our installation d

@spencergilbert
Copy link
Contributor

To clarify here - Aggregator vs Stateless-Aggregator not only affects the presence of a PersistentVolume but also https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#using-statefulsets

The proposed new value would also make this overall change, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants