Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS OpenSearch Serverless for elasticsearch sink #16252

Closed
AvihaiSam opened this issue Feb 2, 2023 · 11 comments · Fixed by #21676
Closed

Support AWS OpenSearch Serverless for elasticsearch sink #16252

AvihaiSam opened this issue Feb 2, 2023 · 11 comments · Fixed by #21676

Comments

@AvihaiSam
Copy link

AWS OpenSearch Serverless Service endpoint is aoss instead of es.

Please add a config to distinguish ES from AOSS, and fix sign_request call.

crate::aws::sign_request("es", request, credentials_provider, region).await

I'm not sure if there are future changes needs to be done afterwards.

@AvihaiSam AvihaiSam changed the title Support AWS OpenSearch Serverless sink Support AWS OpenSearch Serverless for elasticsearch sink Feb 2, 2023
@AvihaiSam AvihaiSam changed the title Support AWS OpenSearch Serverless for elasticsearch sink Support AWS OpenSearch Serverless for elasticsearch sink Feb 2, 2023
@davidhuie-dd
Copy link
Contributor

I agree that we should support this.

@zamazan4ik
Copy link
Contributor

zamazan4ik commented Feb 25, 2023

@AvihaiSam Could you please test the fix from the branch - #16590 ? I have no ability to test it on my own right now. You need to build Vector from the provided PR and test with your setup with AWS OpenSearch Serverless.

Thanks in advance!

@AvihaiSam
Copy link
Author

AvihaiSam commented Feb 25, 2023

Hey @zamazan4ik,
I have actually compiled a different version a week ago and tried it.
I have noticed several things:

  1. the health API is not available
  2. the version API is not available (at this point, my guess is that all the /_cluster APIs are not available)
  3. my sigv4-auth signature was wrong, using the assume-role auth-option (maybe my version made it fail, i'm no rust expert...)
    For the last thing - I have opened a support ticket to AWS and they are looking into it.
    Since this issue makes the cluster impossible to work with we have decided to delete the cluster due do its high costs.
    So - unfortunately, I can no longer test it.

Hope to hear from AWS and will let you know if/when I will have access to a new cluster...

@zamazan4ik
Copy link
Contributor

I have actually compiled a different version a week ago and tried it.

What version did you compile? Does it have the same fixes for AOSS as from my branch?

@AvihaiSam
Copy link
Author

I tried my own implementation here

@handlerbot
Copy link
Contributor

@AvihaiSam 👋🏻 I have interest in getting vector working with OpenSearch Serverless; any objection to me taking what you've got in your tree and seeing what the current gaps are, and me getting it committed with you listed as primary author if I can get to success? Or do you have current plans or thoughts?

@AvihaiSam
Copy link
Author

@handlerbot sure. I left it there hoping someone will find the time to work on that.

@vitalvas
Copy link

I'm so interested in this support. Do you have any progress?

@handlerbot
Copy link
Contributor

handlerbot commented Nov 1, 2024

I have Amazon OpenSearch Serverless support implemented, and a PR is submitted: #21676 🤞🏻

FYI to @AvihaiSam: You were almost there with your earlier branch; the part I had to hurdle was tweaking the params to the AWS Signature V4 call to have it include the x-amz-content-sha256 header: https://github.com/vectordotdev/vector/pull/21676/files#diff-2fefb6a5eb1e6ec14e4df29cc639581b56cab588af42315f89e02bc6b798b8e4R280-R288 . Thank you for your earlier work, sharing it, and letting me run with it to here! 🎉

@AvihaiSam
Copy link
Author

I have Amazon OpenSearch Serverless support implemented, and a PR is submitted: #21676 🤞🏻

FYI to @AvihaiSam: You were almost there with your earlier branch; the part I had to hurdle was tweaking the params to the AWS Signature V4 call to have it include the x-amz-content-sha256 header: https://github.com/vectordotdev/vector/pull/21676/files#diff-2fefb6a5eb1e6ec14e4df29cc639581b56cab588af42315f89e02bc6b798b8e4R280-R288 . Thank you for your earlier work, sharing it, and letting me run with it to here! 🎉

Thanks a lot for this! I had no idea...
Great work!

@handlerbot
Copy link
Contributor

@AvihaiSam You can wipe https://github.com/AvihaiSam/vector/tree/feature/opensearch-serverless now if you want to clean up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants