Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki sink shouldn't convert label names to lowercase during template expansion #19038

Open
precisionconage opened this issue Nov 3, 2023 · 4 comments
Labels
sink: loki Anything `loki` sink related type: bug A code related bug.

Comments

@precisionconage
Copy link

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

Vector converts label names to lowercase during template expansion. Since labels in Loki are case-sensitive, this can result in logs' being assigned the wrong labels.

Configuration

No response

Version

vector 0.33.0 (x86_64-pc-windows-msvc 89605fb 2023-09-27 14:18:24.180809939)

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

@precisionconage precisionconage added the type: bug A code related bug. label Nov 3, 2023
@StephenWakely
Copy link
Contributor

Good call. I'm not sure why it would be converting to lowercase. It's an easy fix, but one we'd need to do carefully in case there are some users relying on that conversion.

@bruceg bruceg added the sink: loki Anything `loki` sink related label Nov 21, 2023
@dsmith3197
Copy link
Contributor

We looked at the original change that introduced this (#12041) and agree that it is not needed. We can remove the lowercase function but need to treat this as a breaking change.

@tiantangkuohai
Copy link

Any updates on this issue? I see lower case label when I use Label Expansion in Loki Sink. It's really annoying.

@pront
Copy link
Contributor

pront commented Nov 8, 2024

Hello, I understand this can be frustrating. Unfortunately, a fix is not prioritized currently. PRs are always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: loki Anything `loki` sink related type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

6 participants