Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Vector release binary is not stripped #20707

Closed
ghost opened this issue Jun 21, 2024 · 1 comment
Closed

The Vector release binary is not stripped #20707

ghost opened this issue Jun 21, 2024 · 1 comment
Labels
type: bug A code related bug.

Comments

@ghost
Copy link

ghost commented Jun 21, 2024

Problem

The Vector release binaries that are installed by the installation script on x86_64 are not stripped. Stripping the binary by running

strip $(which vector)

reduces the binary size tens of megabytes.

It would be good to add stripping of the Vector binary for release builds. I guess the best place to add it is the Makefile.

Version

0.39.0

@ghost ghost added the type: bug A code related bug. label Jun 21, 2024
@jszwedko
Copy link
Member

Hi @a-rodin !

Thanks for opening this! We discussed this before and don't want to strip symbols since it can make bug reports containing stack traces much less useful. For users that don't feel like they need this information, they can of course feel free to strip.

#20064 may also be of interest to you.

I'll close this out, but let me know if you have any additional thoughts or questions!

@jszwedko jszwedko closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

1 participant