Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MQTT sink "retain" flag configurable #21278

Closed
miquelruiz opened this issue Sep 12, 2024 · 1 comment · Fixed by #21291
Closed

Make MQTT sink "retain" flag configurable #21278

miquelruiz opened this issue Sep 12, 2024 · 1 comment · Fixed by #21291
Labels
sink: mqtt Anything `mqtt` sink related type: feature A value-adding code addition that introduce new functionality.

Comments

@miquelruiz
Copy link
Contributor

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

I would like the messages sent to the MQTT sink to be retained by the server.

Attempted Solutions

The MQTT client's publish function accepts a retain flag, which the sink service hardcodes to false

Proposal

I think it should be rather easy to expose a "retain" boolean configuration flag for the sink that allows users to configure this.

I'd be happy to give it a go and submit a PR myself, but opening this issue first so the feature can be considered before I spend time on it.

References

No response

Version

No response

@miquelruiz miquelruiz added the type: feature A value-adding code addition that introduce new functionality. label Sep 12, 2024
@jszwedko jszwedko added the sink: mqtt Anything `mqtt` sink related label Sep 12, 2024
@jszwedko
Copy link
Member

Good spot @miquelruiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: mqtt Anything `mqtt` sink related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants