Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML Merges are not support in Config #21729

Closed
lattwood opened this issue Nov 7, 2024 · 4 comments
Closed

YAML Merges are not support in Config #21729

lattwood opened this issue Nov 7, 2024 · 4 comments
Labels
domain: config Anything related to configuring Vector type: bug A code related bug.

Comments

@lattwood
Copy link

lattwood commented Nov 7, 2024

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

YAML configuration parsing doesn't support merging, part of the YAML 1.1 > spec.

This is due to not calling serde_yaml::apply_merge after serde_yaml::from_str.

I'm opening this issue due to CONTRIBUTING.md saying there should be an issue for pull requests.

Configuration

transforms:
  enhance_node_exporter_data: &enrichRemap
    type: remap
    inputs:
    - node_exporter
    source: |-
      .tags.country = "meta.country"
    enhance_statsd_metrics_data:
      <<: *enrichRemap
      inputs:
      - statsd_metrics


### Version

0.43.0-custom-e2b83f219

### Debug Output

_No response_

### Example Data

_No response_

### Additional Context

_No response_

### References

_No response_
@lattwood lattwood added the type: bug A code related bug. label Nov 7, 2024
@pront pront added the domain: config Anything related to configuring Vector label Nov 7, 2024
@pront
Copy link
Contributor

pront commented Nov 7, 2024

Thank you @lattwood! We will review the PR shortly.

@lattwood
Copy link
Author

lattwood commented Nov 7, 2024

@pront awesome! Can't wait for a release with it so I can dry up my vector config!

@jszwedko
Copy link
Member

jszwedko commented Nov 7, 2024

I think this is a duplicate of #20853 so I'll close this one, but thank you for the PR to address it!

@jszwedko jszwedko closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
@lattwood
Copy link
Author

lattwood commented Nov 7, 2024

Even better, solving a problem others are currently experiencing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: config Anything related to configuring Vector type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

3 participants