Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(greptimedb_logs): provide a default value for greptimedb logs pipeline_name #21739

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sunng87
Copy link
Contributor

@sunng87 sunng87 commented Nov 8, 2024

Summary

The change made pipeline_name for greptimedb log sink an optional configuration item. A default value is provided.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Integration test provided

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • [] Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@sunng87 sunng87 requested review from a team as code owners November 8, 2024 06:50
@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: external docs Anything related to Vector's external, public documentation labels Nov 8, 2024
@pront pront enabled auto-merge November 8, 2024 20:31
@pront
Copy link
Contributor

pront commented Nov 8, 2024

Thanks @sunng87

@sunng87 sunng87 changed the title refactor(greptimedb_logs): provide a default value for greptimedb logs pipeline_name enhancement(greptimedb_logs): provide a default value for greptimedb logs pipeline_name Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants