Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support blpop in older version of redis <v6.0.0 #22061

Open
lambdaq opened this issue Dec 20, 2024 · 2 comments
Open

support blpop in older version of redis <v6.0.0 #22061

lambdaq opened this issue Dec 20, 2024 · 2 comments
Labels
source: redis Anything `redis` source related type: bug A code related bug.

Comments

@lambdaq
Copy link

lambdaq commented Dec 20, 2024

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

async fn blpop(conn: &mut ConnectionManager, key: &str) -> RedisResult<String> {

conn.brpop(key, 0.0)

conn.blpop(key, 0.0)

https://redis.io/docs/latest/commands/brpop/

Starting with Redis version 6.0.0: timeout is interpreted as a double instead of an integer.

Unfortunately we have several old redis instances running and can't use vector for this exact reason

My config

[sources.in]
type = "redis"
data_type = "list"
list.method = "brpop"
key = "sth"
url = "redis://xxxx"

vector::internal_events::redis: Failed to read message. error=An error was signalled by the server - ResponseError: timeout is not an integer or out of range error_code=ERR error_type="reader_failed" stage="sending" internal_log_rate_limit=true

Configuration

No response

Version

latest

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

@lambdaq lambdaq added the type: bug A code related bug. label Dec 20, 2024
@lambdaq lambdaq changed the title support redis blpop in earlier version (v6) support blpop in older version of redis <v6.0.0 Dec 20, 2024
@jszwedko
Copy link
Member

jszwedko commented Dec 20, 2024

Thanks @lambdaq ! I think this would need to be a change in the redis-rs library. I opened redis-rs/redis-rs#1453 if you want to follow along there.

@jszwedko jszwedko added the source: redis Anything `redis` source related label Dec 20, 2024
@lambdaq
Copy link
Author

lambdaq commented Dec 25, 2024

Redis' version lifetime support, which means that 6 is already out of support and 6.2 is soon out of support.

Ahh damn. Guess I have to write my own redis blpop code without vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: redis Anything `redis` source related type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

2 participants