-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Have Vector master
use main
of VRL
#20839
Conversation
So that nightly releases can you unreleased VRL changes for testing. This was requested by a user. I can see the usefulness to be able to validate VRL changes without having to build Vector. As part of the release, we'll switch it to the latest released version (which should be the same SHA). Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense. Noting this important detail from our offline discussion: The lock file guarantees the VRL version is pinned until someone runs cargo update
.
Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
.to_string(); | ||
( | ||
precise.clone(), | ||
format!("{}/tree/{precise}", vrl_source.url()), |
Check warning
Code scanning / check-spelling
Candidate Pattern Warning
Signed-off-by: Jesse Szwedko <[email protected]>
Replaced by #21417 |
Pull request was closed
So that nightly releases can you unreleased VRL changes for testing. This was requested by a user. I can see the usefulness to be able to validate VRL changes without having to build Vector.
This depends on Dependabot updating VRL. I'm not sure if it handles
git
dependencies, but we'll see. If it doesn't, I'll back out this change.As part of the release, we'll switch it to the latest released version (which should be the same SHA).