Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Have Vector master use main of VRL #20839

Closed
wants to merge 6 commits into from

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Jul 10, 2024

So that nightly releases can you unreleased VRL changes for testing. This was requested by a user. I can see the usefulness to be able to validate VRL changes without having to build Vector.

This depends on Dependabot updating VRL. I'm not sure if it handles git dependencies, but we'll see. If it doesn't, I'll back out this change.

As part of the release, we'll switch it to the latest released version (which should be the same SHA).

So that nightly releases can you unreleased VRL changes for testing. This was requested by a user.
I can see the usefulness to be able to validate VRL changes without having to build Vector.

As part of the release, we'll switch it to the latest released version (which should be the same
SHA).

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jul 10, 2024
@pront pront self-requested a review September 3, 2024 15:15
@jszwedko jszwedko requested a review from a team as a code owner September 4, 2024 15:14
Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Noting this important detail from our offline discussion: The lock file guarantees the VRL version is pinned until someone runs cargo update.

Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
.to_string();
(
precise.clone(),
format!("{}/tree/{precise}", vrl_source.url()),

Check warning

Code scanning / check-spelling

Candidate Pattern Warning

Line matches candidate pattern "\burl\([^\)]*\)" (candidate-pattern)
Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
Copy link
Member Author

jszwedko commented Oct 3, 2024

Replaced by #21417

@jszwedko jszwedko closed this Oct 3, 2024
auto-merge was automatically disabled October 3, 2024 19:47

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants