feat: Adds @register_theme decorator
#3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves one item in vega#3519
Adds `@register_theme` to top-level
The latter may give false-positives for json-incompatible dicts
|
Will probably need to resolve some conflicts after merging EditAll good to go again |
dangotbanned
commented
Aug 9, 2024
binste
requested changes
Sep 4, 2024
Thanks for getting to this @binste and no worries on the timing; this is a mini-feature after all 😄 |
binste
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Good point, having autocompletion trumps type hint flexibility in this case, wasn't aware that we can't have both. Thanks for the explanation!
Would you mind just adding the link to your GitHub comment as a Python comment next to the LiteralString type hints in register_theme and in the ThemeRegistry? Else, I'll probably change the type hint in a few months when I've forgotten why LiteralString is better :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves one item in #3519
Fairly simple addition, but it is a nice convenience when you only use a single theme.
I also added an example that might be relevant to @joelostblom #3519 (comment)
The decorator also works well with type checkers: