Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add ThemeConfig section to User Guide #3645

Open
dangotbanned opened this issue Oct 20, 2024 · 0 comments
Open

docs: Add ThemeConfig section to User Guide #3645

dangotbanned opened this issue Oct 20, 2024 · 0 comments

Comments

@dangotbanned
Copy link
Member

dangotbanned commented Oct 20, 2024

Description

Work-in-progress

What

Show how this benefits:

Typing users

  • Autocomplete
  • Static validation
  • Doesn't require using class-syntax
    • Can be used to see docs
  • Compare the UX to that of Vega Editor

Non-typing users

  • Class-syntax is required for completions
  • Still likely an improvement over using a dict
  • Point to resources on how they can get the full benefits

Where

Either

Related

Have you considered any alternative solutions?

We can leave chart-themes in the same state as left by #3618

I think @joelostblom's comment shows why this feature warrants further explanation.

The only alternative I see would be linking to typing-spec-TypedDict.
However, I did this in #3536-description and that alone did not suffciently convey the benefits to reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant