Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash - missing camera transitionPeriod #58

Closed
drdozer opened this issue Oct 9, 2023 · 4 comments
Closed

crash - missing camera transitionPeriod #58

drdozer opened this issue Oct 9, 2023 · 4 comments

Comments

@drdozer
Copy link
Contributor

drdozer commented Oct 9, 2023

With pymods installed and others, on adding DeadlocksStackingForPyanadon, but loading a vanilla map, although that's likely incidental:

  61.642 Applying migration: Time Lapse Base Edition: tlbe-0.2.1.lua
  61.642 Applying migration: Time Lapse Base Edition: tlbe-1.0.0.lua
  61.642 Applying migration: Time Lapse Base Edition: tlbe.1.1.1.lua
  61.643 Applying migration: Time Lapse Base Edition: tlbe.1.2.0.lua
  61.643 Applying migration: Time Lapse Base Edition: tlbe.1.3.1.lua
  61.643 Applying migration: Time Lapse Base Edition: tlbe.1.4.2.lua
  61.643 Applying migration: Time Lapse Base Edition: tlbe.1.4.3.lua
  61.643 Applying migration: Time Lapse Base Edition: tlbe.1.4.4.lua
  61.643 Applying migration: Time Lapse Base Edition: tlbe.1.4.5.lua
  62.651 Error AppManagerStates.cpp:1662: Error while applying migration: Time Lapse Base Edition: tlbe.1.4.5.lua

__TLBE__/scripts/camera.lua:104: attempt to perform arithmetic on field 'transitionPeriod' (a nil value)
stack traceback:
	__TLBE__/scripts/camera.lua:104: in function 'updateConfig'
	__TLBE__/migrations/tlbe.1.4.5.lua:55: in main chunk

I haven't looked at the code yet -- I'm betting it is some inconsistency in the behaviour of the green box tracking to the white one.

@veger
Copy link
Owner

veger commented Oct 9, 2023

I think it is similar to #55 (comment), somehow the Camera is in an incorrect state, and then the updateConfig function has nil values which Lua cannot do maths with...

The Camera property zoomPeriod got renamed to transitionPeriod (see https://github.com/veger/TLBE/blob/master/migrations/tlbe.1.4.5.lua#L52C15-L52C15). This rename seems to be missing in your save file.

@drdozer
Copy link
Contributor Author

drdozer commented Oct 26, 2023

Weird. The same issue has not happened again, so I have no idea how to reproduce it. I guess we can leave this until someone else reports it or it happens in a controlled environment where we can fix it properly?

@veger veger changed the title crash crash - missing camera transitionPeriod Oct 26, 2023
@veger
Copy link
Owner

veger commented Oct 26, 2023

As mentioned it looks similar to #55 (if my deduction is correct, it is due to people running directly from code and thereby missing out on the (changed) migrations in between releases). I cannot see another path that results in the missing properties for the Camera. Within this controlled environment it is reproducible, but it becomes quite unlikely if there are more reports as I doubt lots of people are running 'in between' versions...

We can leave this issue open for a while to see if there are more reports coming in

@veger
Copy link
Owner

veger commented Nov 13, 2023

Fixed in v1.5.1

@veger veger closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants