Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added guide on how to make an entity channel aware #3209

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

Draykee
Copy link
Contributor

@Draykee Draykee commented Nov 14, 2024

Description

Issue #3210

  • Fixed wrong link to customer group instead of customer
  • Added guide on how to make an entity channel aware
  • Improve the documentation of the assignToCurrentChannel helper, since it sounds like it will perform database operations

Breaking changes

Nope

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ❌ Failed (Inspect) Jan 22, 2025 7:09am

Copy link
Contributor

github-actions bot commented Nov 14, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Draykee
Copy link
Contributor Author

Draykee commented Nov 14, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and comprehensive guide! Just a bunch of small fixes/improvements to add.

@Draykee
Copy link
Contributor Author

Draykee commented Nov 25, 2024

Anything missing? Would love to get this merged to start delivering the guide for translateables

@Draykee
Copy link
Contributor Author

Draykee commented Nov 25, 2024

I have read the CLA Document and I hereby sign the CLA

@michaelbromley
Copy link
Member

recheck

@michaelbromley
Copy link
Member

Looks like there are broken links: https://vercel.com/vendure/docs/Pt79zh5qPKN27xgjmhATpQLwiX5p?filter=errors

Run npm run build from the docs dir locally and you'll see them too.

@michaelbromley michaelbromley added the docs 📖 Documentation fixes or improvements label Dec 31, 2024
@michaelbromley michaelbromley added this to the v3.1.2 milestone Dec 31, 2024
@michaelbromley michaelbromley merged commit 7e90ddc into vendure-ecommerce:master Jan 22, 2025
27 of 29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs 📖 Documentation fixes or improvements
Projects
Status: 💯 Ready
Development

Successfully merging this pull request may close these issues.

2 participants